Bug 194495

Summary: [GStreamer] GstMappedBuffer testsuite build fails
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, commit-queue, cturner, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 192977    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2019-02-11 02:46:34 PST
+++ This bug was initially created as a clone of Bug #192977 +++ [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite In file included from ../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:25:0, from ../Source/WebCore/platform/SharedBuffer.h:52, from ../Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:32: ../Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h:24:10: fatal error: gst/audio/audio.h: No such file or directory #include <gst/audio/audio.h> ^~~~~~~~~~~~~~~~~~~ compilation terminated. This happens only if I try to build within my gst-build environment, the fix is trivial. Attaching a patch...
Attachments
Patch (1.75 KB, patch)
2019-02-11 02:49 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2019-02-11 02:49:47 PST
Created attachment 361669 [details] Patch
WebKit Commit Bot
Comment 2 2019-02-11 04:14:55 PST
Comment on attachment 361669 [details] Patch Clearing flags on attachment: 361669 Committed r241261: <https://trac.webkit.org/changeset/241261>
WebKit Commit Bot
Comment 3 2019-02-11 04:14:57 PST
All reviewed patches have been landed. Closing bug.
Xabier Rodríguez Calvar
Comment 4 2019-02-11 06:00:27 PST
Good, nice catch.
Note You need to log in before you can comment on or make changes to this bug.