| Summary: | Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases) | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | dbates, ews-watchlist, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 30342 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Darin Adler
2019-02-10 16:53:40 PST
Created attachment 361652 [details]
Patch
Created attachment 361654 [details]
Patch
Created attachment 361658 [details]
Patch
Created attachment 361889 [details]
Patch
Comment on attachment 361889 [details] Patch Attachment 361889 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11132151 New failing tests: http/tests/inspector/network/resource-initiatorNode.html Created attachment 361902 [details]
Archive of layout-test-results from ews114 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
These crashes in PixelBufferConformerCV::convert are ones that I saw on another patch of mine as well, and have nothing to do with this patch. Comment on attachment 361889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361889&action=review > Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:54 > - String filename = String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s", resource, extension); > + String filename = makeString("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\", resource, '.', extension); My eyes! Raw strings will save us. No change necessary. > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:618 > + if (parentName && parentName[0]) { Nice! > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:631 > + builder.appendNumber(element->x(), 6, KeepTrailingZeros); No chance necessary. Not so nice in my eyes :/ Comment on attachment 361889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361889&action=review >> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:631 >> + builder.appendNumber(element->x(), 6, KeepTrailingZeros); > > No chance necessary. Not so nice in my eyes :/ The long term is that we want more people to use the default formatting for doubles rather than choosing the strange "6 digit precision with trailing zeros" format. We’ll come through later to simplify that. Committed r241587: <https://trac.webkit.org/changeset/241587> |