Bug 194480

Summary: Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, ap, beidson, cdumez, commit-queue, ggaren, koivisto, lforschler, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=194481
https://bugs.webkit.org/show_bug.cgi?id=194545
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2019-02-10 04:58:03 PST
TestWebKitAPI.ProcessSwap.SessionStorage seems flaky. In https://ews-build.webkit-uat.org/#/builders/20/builds/819, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed. Same thing happened in https://ews-build.webkit-uat.org/#/builders/20/builds/829
Attachments
Patch (30.28 KB, patch)
2019-02-27 15:28 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (30.20 KB, patch)
2019-02-27 15:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-02-12 06:37:23 PST
Another one: https://ews-build.webkit-uat.org/#/builders/20/builds/880 (different test failure in re-run)
Aakash Jain
Comment 2 2019-02-27 05:54:55 PST
Can we prioritize this? I am working on EWS for API tests, and this flaky failure is creating problem.
Chris Dumez
Comment 3 2019-02-27 06:55:55 PST
(In reply to Aakash Jain from comment #2) > Can we prioritize this? > I am working on EWS for API tests, and this flaky failure is creating > problem. Ok, I think I should have some time to look into this today.
Chris Dumez
Comment 4 2019-02-27 12:16:30 PST
It looks like sometimes, when StorageManager::setItem() is called, findStorageArea(connection, storageMapID) returns null, so we fail to set the item.
Chris Dumez
Comment 5 2019-02-27 12:39:13 PST
It is very weird, I see the StorageManager::CreateSessionStorageMap() getting sent by the WebProcess, then the StorageManager::SetItem() getting sent by the WebProcess. However, when it fails, on the UIProcess side, I see StorageManager::setItem() getting called but not StorageManager::createSessionStorageMap(). I added an assertion on sending side and it did not hit so the sender side believes that it was successful sending both IPC messages. Both IPC messages are async so there is no way they could be processed out of order..
Chris Dumez
Comment 6 2019-02-27 15:28:44 PST
Created attachment 363141 [details] Patch
Chris Dumez
Comment 7 2019-02-27 15:43:10 PST
Created attachment 363147 [details] Patch
WebKit Commit Bot
Comment 8 2019-02-27 16:54:25 PST
Comment on attachment 363147 [details] Patch Clearing flags on attachment: 363147 Committed r242182: <https://trac.webkit.org/changeset/242182>
WebKit Commit Bot
Comment 9 2019-02-27 16:54:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-02-27 17:40:59 PST
<rdar://problem/48458499>
Note You need to log in before you can comment on or make changes to this bug.