Bug 194473 – [LFC][IFC] Add intrinsic width support for basic inline containers

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

<span>foobar</span>

[zalan]

Created attachment 361607 [details]
Patch

[Antti Koivisto]

Comment on attachment 361607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361607&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:138
> +void InlineFormattingContext::computeBorderAndPadding(const Box& layoutBox, UsedHorizontalValues usedValues) const
> +{
> +    auto& displayBox = layoutState().displayBoxForLayoutBox(layoutBox);
> +    displayBox.setBorder(Geometry::computedBorder(layoutBox));
> +    displayBox.setPadding(Geometry::computedPadding(layoutBox, usedValues));
> +}

This is in addition to FormattingContext::computeBorderAndPadding, right? Is there something inline specific here?

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 361607 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361607&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:138
> > +void InlineFormattingContext::computeBorderAndPadding(const Box& layoutBox, UsedHorizontalValues usedValues) const
> > +{
> > +    auto& displayBox = layoutState().displayBoxForLayoutBox(layoutBox);
> > +    displayBox.setBorder(Geometry::computedBorder(layoutBox));
> > +    displayBox.setPadding(Geometry::computedPadding(layoutBox, usedValues));
> > +}
> 
> This is in addition to FormattingContext::computeBorderAndPadding, right? Is
> there something inline specific here?
Not at all. I am going to consolidate them once I am done with the intrinsic width patches.

[WebKit Commit Bot]

Comment on attachment 361607 [details]
Patch

Clearing flags on attachment: 361607

Committed r241243: <https://trac.webkit.org/changeset/241243>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47943846>