Bug 194464

Summary: GCHeapInspector: Show the retained sizes in more places
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, lforschler, simon.fraser, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[IMAGE] Retained Sizes
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2019-02-08 16:36:34 PST
Show the retained sizes in more places Turns out the page already had node-size with a `display: none`. Add the retained size to a few other places and color them blue.
Attachments
[IMAGE] Retained Sizes (1.41 MB, image/png)
2019-02-08 16:36 PST, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (4.05 KB, patch)
2019-02-08 16:37 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-02-08 16:36:51 PST
Created attachment 361560 [details] [IMAGE] Retained Sizes
Joseph Pecoraro
Comment 2 2019-02-08 16:37:28 PST
Created attachment 361562 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2019-02-11 11:25:56 PST
Comment on attachment 361562 [details] [PATCH] Proposed Fix Clearing flags on attachment: 361562 Committed r241274: <https://trac.webkit.org/changeset/241274>
WebKit Commit Bot
Comment 4 2019-02-11 11:25:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-02-11 11:26:39 PST
<rdar://problem/47971950>
Note You need to log in before you can comment on or make changes to this bug.