| Summary: | Add more more test for clampTo<>() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, ggaren, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Poulain
2019-02-08 16:14:46 PST
Created attachment 361555 [details]
Patch
Created attachment 361589 [details]
Patch
Comment on attachment 361589 [details]
Patch
r=me
Comment on attachment 361589 [details]
Patch
Great, that’s exactly what I had in mind. Could do the same for float.
Comment on attachment 361589 [details]
Patch
Thanks for the reviews.
Before adding float I'd like to go back to the timer optimizations.
(In reply to Benjamin Poulain from comment #5) > Before adding float I'd like to go back to the timer optimizations. Yes, I agree, that’s way more valuable. I think you’ve already spent enough time on this. A nice idea to come back later and do a tiny bit more minor tweaking on the tests, but not really important at all. I didn’t mean to keep you stuck on this. Comment on attachment 361589 [details] Patch Clearing flags on attachment: 361589 Committed r241247: <https://trac.webkit.org/changeset/241247> All reviewed patches have been landed. Closing bug. |