Bug 194462

Summary: Add more more test for clampTo<>()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2019-02-08 16:14:46 PST
Add more more test for clampTo<>()
Attachments
Patch (3.01 KB, patch)
2019-02-08 16:23 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (3.00 KB, patch)
2019-02-08 20:13 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2019-02-08 16:23:11 PST
Created attachment 361555 [details] Patch
Benjamin Poulain
Comment 2 2019-02-08 20:13:45 PST
Created attachment 361589 [details] Patch
Geoffrey Garen
Comment 3 2019-02-08 22:07:48 PST
Comment on attachment 361589 [details] Patch r=me
Darin Adler
Comment 4 2019-02-09 09:48:34 PST
Comment on attachment 361589 [details] Patch Great, that’s exactly what I had in mind. Could do the same for float.
Benjamin Poulain
Comment 5 2019-02-09 16:16:29 PST
Comment on attachment 361589 [details] Patch Thanks for the reviews. Before adding float I'd like to go back to the timer optimizations.
Darin Adler
Comment 6 2019-02-09 16:31:40 PST
(In reply to Benjamin Poulain from comment #5) > Before adding float I'd like to go back to the timer optimizations. Yes, I agree, that’s way more valuable. I think you’ve already spent enough time on this. A nice idea to come back later and do a tiny bit more minor tweaking on the tests, but not really important at all. I didn’t mean to keep you stuck on this.
WebKit Commit Bot
Comment 7 2019-02-09 16:42:01 PST
Comment on attachment 361589 [details] Patch Clearing flags on attachment: 361589 Committed r241247: <https://trac.webkit.org/changeset/241247>
WebKit Commit Bot
Comment 8 2019-02-09 16:42:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-02-09 16:47:08 PST
<rdar://problem/47945009>
Note You need to log in before you can comment on or make changes to this bug.