Summary: | [ews-build] Ensure that every builder in config.json has short name | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, lforschler, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=194456 | ||||||
Attachments: |
|
Description
Aakash Jain
2019-02-08 15:51:32 PST
Created attachment 361548 [details]
Proposed patch
Comment on attachment 361548 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=361548&action=review > Tools/BuildSlaveSupport/ews-build/loadConfig.py:105 > + raise Exception('Builder "{}" does not have short name defined. This name is needed for EWS status-bubbles.'.format(builder.get('name'))) I don't think status bubbles should be hyphenated. > Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py:113 > + self.assertEqual(context.exception.args, ('Builder "mac-wk2(test)" does not have short name defined. This name is needed for EWS status-bubbles.',)) ditto Committed r241221: <https://trac.webkit.org/changeset/241221> |