Bug 194452

Summary: Use maxSingleCharacterString in comparisons instead of literal constants.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2019-02-08 14:41:58 PST
This way, if we ever change maxSingleCharacterString, it won't break all this code that relies on it being 0xff implicitly.
Attachments
proposed patch. (5.17 KB, patch)
2019-02-08 14:44 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-02-08 14:44:39 PST
Created attachment 361536 [details] proposed patch.
Yusuke Suzuki
Comment 2 2019-02-08 14:47:03 PST
Comment on attachment 361536 [details] proposed patch. r=me
Mark Lam
Comment 3 2019-02-08 15:07:22 PST
Thanks for the review. Landed in r241214: <http://trac.webkit.org/r241214>.
Radar WebKit Bug Importer
Comment 4 2019-02-08 15:09:29 PST
<rdar://problem/47931478>
Note You need to log in before you can comment on or make changes to this bug.