Bug 194442

Summary: Abstract and discussion comments needed for afterScreenUpdates
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, ggaren, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch wenson_hsieh: review+

Beth Dakin
Reported 2019-02-08 11:02:56 PST
Forgot to add abstract and discussion comments with https://trac.webkit.org/changeset/241199/webkit Oops!
Attachments
Patch (1.45 KB, patch)
2019-02-08 11:05 PST, Beth Dakin 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2019-02-08 11:05:32 PST
Created attachment 361517 [details] Patch
Beth Dakin
Comment 2 2019-02-08 12:36:30 PST
Thanks Wenson! https://trac.webkit.org/changeset/241204/webkit
Radar WebKit Bug Importer
Comment 3 2019-02-08 12:37:29 PST
<rdar://problem/47926053>
Tim Horton
Comment 4 2019-02-08 12:56:48 PST
Comment on attachment 361517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361517&action=review > Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.h:53 > + which might not include recent changes. This has to be a MAY not a WILL :D
Tim Horton
Comment 5 2019-02-08 12:58:27 PST
Comment on attachment 361517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361517&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.h:53 >> + which might not include recent changes. > > This has to be a MAY not a WILL :D Wait, it is. The earlier will in the sentence is weird
Note You need to log in before you can comment on or make changes to this bug.