Bug 194442 - Abstract and discussion comments needed for afterScreenUpdates
Summary: Abstract and discussion comments needed for afterScreenUpdates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-08 11:02 PST by Beth Dakin
Modified: 2019-02-08 12:58 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2019-02-08 11:05 PST, Beth Dakin
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2019-02-08 11:02:56 PST
Forgot to add abstract and discussion comments with https://trac.webkit.org/changeset/241199/webkit Oops!
Comment 1 Beth Dakin 2019-02-08 11:05:32 PST
Created attachment 361517 [details]
Patch
Comment 2 Beth Dakin 2019-02-08 12:36:30 PST
Thanks Wenson! https://trac.webkit.org/changeset/241204/webkit
Comment 3 Radar WebKit Bug Importer 2019-02-08 12:37:29 PST
<rdar://problem/47926053>
Comment 4 Tim Horton 2019-02-08 12:56:48 PST
Comment on attachment 361517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361517&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.h:53
> + which might not include recent changes.

This has to be a MAY not a WILL :D
Comment 5 Tim Horton 2019-02-08 12:58:27 PST
Comment on attachment 361517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361517&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.h:53
>> + which might not include recent changes.
> 
> This has to be a MAY not a WILL :D

Wait, it is. The earlier will in the sentence is weird