Summary: | Export MathML fraction tests to WPT | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, dbarton, ews-watchlist, rbuis, rego, rniwa, rwlbuis, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://github.com/web-platform-tests/wpt/pull/15301 | ||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2019-02-08 09:02:07 PST
Created attachment 362733 [details]
Patch
Comment on attachment 362733 [details] Patch Attachment 362733 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11249329 New failing tests: imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html Created attachment 362743 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 362744 [details]
Patch
Comment on attachment 362744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362744&action=review LGTM, but I'd update the ChangeLog message before landing. > LayoutTests/imported/w3c/ChangeLog:6 > + This is just an import of the current MathML WPT tests. It includes fraction tests from This is not accurate, this is not only an import, you're also exporting some tests here. Comment on attachment 362744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362744&action=review >> LayoutTests/imported/w3c/ChangeLog:6 >> + This is just an import of the current MathML WPT tests. It includes fraction tests from > > This is not accurate, this is not only an import, you're also exporting some tests here. Yes, but this is explained in the other ChangeLog. Comment on attachment 362744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362744&action=review LGTM as well. > LayoutTests/ChangeLog:7 crashes. Created attachment 362980 [details]
Patch
@Rego, @Rob: Same patch uploaded with tweaks in the ChangeLogs. Comment on attachment 362980 [details]
Patch
Ok, I thought I did r+ the other day sorry.
Comment on attachment 362980 [details] Patch Rejecting attachment 362980 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 362980, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/11290374 Committed r242085: <https://trac.webkit.org/changeset/242085> |