Bug 194436

Summary:

Export MathML fraction tests to WPT

Product:

WebKit

Reporter:

Frédéric Wang Nélar <fred.wang>

Component:

MathML

Assignee:

Frédéric Wang Nélar <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbarton, ews-watchlist, rbuis, rego, rniwa, rwlbuis, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://github.com/web-platform-tests/wpt/pull/15301

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-highsierra	none
Patch	none
Patch	rego: review+, commit-queue: commit-queue-

Frédéric Wang Nélar

Reported 2019-02-08 09:02:07 PST

We have several reftests for fractions that can be exported to WPT. Some of the tests have equivalent (and more reliable testing) in WPT and can be removed. Others that just verify crashs/asserts, hangs or invalid markup and be moved up to LayoutTests/mathml/

Attachments
Patch (223.24 KB, patch) 2019-02-22 10:52 PST, Frédéric Wang Nélar	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (2.44 MB, application/zip) 2019-02-22 12:20 PST, EWS Watchlist	no flags	Details
Patch (224.75 KB, patch) 2019-02-22 12:24 PST, Frédéric Wang Nélar	no flags	Details Formatted Diff Diff
Patch (224.96 KB, patch) 2019-02-26 06:45 PST, Frédéric Wang Nélar	rego: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang Nélar

Comment 1 2019-02-22 10:52:06 PST

Created attachment 362733 [details] Patch

EWS Watchlist

Comment 2 2019-02-22 12:20:03 PST

Comment on attachment 362733 [details] Patch Attachment 362733 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11249329 New failing tests: imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html

EWS Watchlist

Comment 3 2019-02-22 12:20:05 PST

Created attachment 362743 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

Frédéric Wang Nélar

Comment 4 2019-02-22 12:24:03 PST

Created attachment 362744 [details] Patch

Manuel Rego Casasnovas

Comment 5 2019-02-24 03:31:18 PST

Comment on attachment 362744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362744&action=review LGTM, but I'd update the ChangeLog message before landing. > LayoutTests/imported/w3c/ChangeLog:6 > + This is just an import of the current MathML WPT tests. It includes fraction tests from This is not accurate, this is not only an import, you're also exporting some tests here.

Frédéric Wang Nélar

Comment 6 2019-02-24 05:42:18 PST

Comment on attachment 362744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362744&action=review >> LayoutTests/imported/w3c/ChangeLog:6 >> + This is just an import of the current MathML WPT tests. It includes fraction tests from > > This is not accurate, this is not only an import, you're also exporting some tests here. Yes, but this is explained in the other ChangeLog.

Rob Buis

Comment 7 2019-02-26 02:20:34 PST

Comment on attachment 362744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362744&action=review LGTM as well. > LayoutTests/ChangeLog:7 crashes.

Frédéric Wang Nélar

Comment 8 2019-02-26 06:45:12 PST

Created attachment 362980 [details] Patch

Frédéric Wang Nélar

Comment 9 2019-02-26 06:46:47 PST

@Rego, @Rob: Same patch uploaded with tweaks in the ChangeLogs.

Manuel Rego Casasnovas

Comment 10 2019-02-26 07:20:18 PST

Comment on attachment 362980 [details] Patch Ok, I thought I did r+ the other day sorry.

WebKit Commit Bot

Comment 11 2019-02-26 07:24:19 PST

Comment on attachment 362980 [details] Patch Rejecting attachment 362980 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 362980, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/11290374

Frédéric Wang Nélar

Comment 12 2019-02-26 07:29:47 PST

Committed r242085: <https://trac.webkit.org/changeset/242085>

Radar WebKit Bug Importer

Comment 13 2019-02-26 07:30:27 PST

<rdar://problem/48400036>

Note You need to log in before you can comment on or make changes to this bug.