Bug 194393

Summary: Fix responsive design issues for the Contribute menu and Feature Status navigation
Product: WebKit Reporter: Jon Davis <jond>
Component: WebKit WebsiteAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, jond, nvasilyev, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jon Davis
Reported 2019-02-07 08:20:18 PST
In Safari on macOS, small windows with very short window height and small enough width (just before the menus collapse to a chevron) causes the Contribute drop-down menu to render incorrectly, and the Feature Status and CSS Features navigation do not resize to accommodate wrapped text.
Attachments
Patch (1.86 KB, patch)
2019-02-07 08:27 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2019-02-07 08:27:08 PST
Created attachment 361395 [details] Patch
Nikita Vasilyev
Comment 2 2019-02-07 11:46:39 PST
Comment on attachment 361395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361395&action=review > Websites/webkit.org/wp-content/themes/webkit/style.css:2514 > +@media only screen and (max-height: 415px) and (max-width: 920px) { Is this for the horizontal mode on iPhone-sized devices?
Jon Davis
Comment 3 2019-02-07 11:58:14 PST
Yes it is.
Nikita Vasilyev
Comment 4 2019-02-07 12:21:04 PST
Looks good! I'd r+
Devin Rousso
Comment 5 2019-02-07 16:38:40 PST
Comment on attachment 361395 [details] Patch rs=me
WebKit Commit Bot
Comment 6 2019-02-07 16:52:53 PST
Comment on attachment 361395 [details] Patch Clearing flags on attachment: 361395 Committed r241173: <https://trac.webkit.org/changeset/241173>
WebKit Commit Bot
Comment 7 2019-02-07 16:52:55 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-02-07 16:53:27 PST
<rdar://problem/47903067>
Note You need to log in before you can comment on or make changes to this bug.