Bug 194357

Summary: Really enable the automatic checking and regenerations of .xcfilelists during builds
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, cdumez, commit-queue, ews-watchlist, keith_miller, lforschler, mark.lam, msaboff, saam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-02-06 13:09:03 PST
Bug 194124 was supposed to enable the automatic checking and regenerating of .xcfilelist files during the build. While related changes were included in that patch, the change to actually enable the operation somehow was omitted. This patch actually enables the operation. The check-xcfilelist.sh scripts now check WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer from the checking.
Attachments
Patch (8.72 KB, patch)
2019-02-06 13:46 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-06 13:09:29 PST
<rdar://problem/47861231>
Keith Rollin
Comment 2 2019-02-06 13:46:16 PST
Created attachment 361324 [details] Patch
Chris Dumez
Comment 3 2019-02-06 13:47:48 PST
Comment on attachment 361324 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2019-02-06 14:55:00 PST
Comment on attachment 361324 [details] Patch Clearing flags on attachment: 361324 Committed r241103: <https://trac.webkit.org/changeset/241103>
WebKit Commit Bot
Comment 5 2019-02-06 14:55:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.