Bug 194355

Summary: [ews-app] Fetch builder id to name mapping
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2019-02-06 12:21:28 PST
ews-app should fetch builder id to name mapping from Buildbot so that it can display the builer name appropriately on EWS status bubbles.
Attachments
Proposed patch (2.28 KB, patch)
2019-02-06 12:52 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-02-06 12:52:53 PST
Created attachment 361319 [details] Proposed patch
Lucas Forschler
Comment 2 2019-02-12 15:17:24 PST
Comment on attachment 361319 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=361319&action=review > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:63 > + builder_id = builder['builderid'] do you want to use a .get here as well?
WebKit Commit Bot
Comment 3 2019-02-13 16:16:22 PST
Comment on attachment 361319 [details] Proposed patch Clearing flags on attachment: 361319 Committed r241485: <https://trac.webkit.org/changeset/241485>
WebKit Commit Bot
Comment 4 2019-02-13 16:16:23 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-02-13 16:19:19 PST
<rdar://problem/48056974>
Note You need to log in before you can comment on or make changes to this bug.