Bug 194341

Summary:

Build failure after r240315

Product:

WebKit

Reporter:

Pablo Saavedra <psaavedra>

Component:

WebCore JavaScript

Assignee:

Pablo Saavedra <psaavedra>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, rniwa, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none

Pablo Saavedra

Reported 2019-02-06 05:23:51 PST

Description: Failure happens building WPE with no VIDEO enabled (proably happens as well in other ports): -DENABLE_VIDEO=OFF -DPORT=WPE Diagnosis: JSC namespace not added to the Webcore namespace when video disabled Build errors: In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-68aea4ac-14.cpp:6: /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp: At global scope: /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp:41:91: error: 'SlotVisitor' has not been declared bool JSUndoItemOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor, const char** reason) In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-68aea4ac-14.cpp:6: /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp: In member function 'virtual bool WebCore::JSUndoItemOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void*, JSC::SlotVisitor&, const char**)': /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp:46:33: error: 'jsCast' was not declared in this scope auto* documentForUndoItem = jsCast<JSUndoItem*>(handle.slot()->asCell())->wrapped().document(); ^~~~~~ Related to: https://bugs.webkit.org/show_bug.cgi?id=193111

Attachments
patch (1.80 KB, patch) 2019-02-06 05:26 PST, Pablo Saavedra	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pablo Saavedra

Comment 1 2019-02-06 05:26:10 PST

Created attachment 361292 [details] patch

WebKit Commit Bot

Comment 2 2019-02-06 07:40:36 PST

Comment on attachment 361292 [details] patch Clearing flags on attachment: 361292 Committed r241017: <https://trac.webkit.org/changeset/241017>

WebKit Commit Bot

Comment 3 2019-02-06 07:40:37 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 4 2019-02-06 07:41:28 PST

<rdar://problem/47849690>

Note You need to log in before you can comment on or make changes to this bug.