Bug 194331

Summary: [JSC] NativeExecutable should be smaller
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, msaboff, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2019-02-06 00:50:36 PST
I think it can be <= 64. (Now, it takes 88).
Attachments
Patch (46.16 KB, patch)
2019-02-06 01:47 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-02-06 01:47:26 PST
Created attachment 361283 [details] Patch
Yusuke Suzuki
Comment 2 2019-02-06 03:20:06 PST
Comment on attachment 361283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361283&action=review > Source/JavaScriptCore/ChangeLog:16 > + they are not touched from JIT, we can remove them from ExecutableBase and move them to ScriptExecutable. Actually, these fields are meaningless even in ScriptExecutable. It is used as a flag. So I would like to shrink FunctionExecutable more in a separate patch.
Michael Saboff
Comment 3 2019-02-06 11:22:46 PST
Comment on attachment 361283 [details] Patch r=me
Yusuke Suzuki
Comment 4 2019-02-06 11:24:28 PST
Comment on attachment 361283 [details] Patch Thanks!
WebKit Commit Bot
Comment 5 2019-02-06 11:49:09 PST
Comment on attachment 361283 [details] Patch Clearing flags on attachment: 361283 Committed r241037: <https://trac.webkit.org/changeset/241037>
WebKit Commit Bot
Comment 6 2019-02-06 11:49:11 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-02-06 11:50:31 PST
<rdar://problem/47858258>
Note You need to log in before you can comment on or make changes to this bug.