Bug 194313

Summary: fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bdakin, commit-queue, lforschler, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193767
Attachments:
Description Flags
Patch
none
Patch none

Description Jonathan Bedard 2019-02-05 15:47:34 PST 
This prevents us from running fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html. On iPad, calendarTypeString will not be defined.
Comment 1 Wenson Hsieh 2019-02-11 09:09:53 PST 
Created attachment 361684 [details]
Patch
Comment 2 Jonathan Bedard 2019-02-11 09:46:40 PST 
Don't we need to un-skip this test on iPad in this patch too?
Comment 3 Wenson Hsieh 2019-02-11 09:49:29 PST 
(In reply to Jonathan Bedard from comment #2)
> Don't we need to un-skip this test on iPad in this patch too?

Good catch :)
Comment 4 Wenson Hsieh 2019-02-11 09:50:04 PST 
Created attachment 361688 [details]
Patch
Comment 5 Wenson Hsieh 2019-02-11 11:01:56 PST 
Comment on attachment 361688 [details]
Patch

Thanks for the review!
Comment 6 WebKit Commit Bot 2019-02-11 11:30:11 PST 
Comment on attachment 361688 [details]
Patch

Clearing flags on attachment: 361688

Committed r241275: <https://trac.webkit.org/changeset/241275>
Comment 7 WebKit Commit Bot 2019-02-11 11:30:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-02-11 11:32:01 PST 
<rdar://problem/47972170>