Summary: | Make sure to clear sources from UserMediaCaptureManagerProxy and UserMediaCaptureManager when no longer needed | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2019-02-05 15:34:25 PST
Created attachment 361232 [details]
Patch
Attachment 361232 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:214: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 361347 [details]
Patch
Attachment 361347 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:214: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 361412 [details]
Patch for landing
Attachment 361412 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:214: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 361412 [details] Patch for landing Clearing flags on attachment: 361412 Committed r241132: <https://trac.webkit.org/changeset/241132> All reviewed patches have been landed. Closing bug. |