Bug 194312

Summary: Make sure to clear sources from UserMediaCaptureManagerProxy and UserMediaCaptureManager when no longer needed
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2019-02-05 15:34:25 PST
Make to clear sources from UserMediaCaptureManagerProxy and UserMediaCaptureManager when no longer needed
Attachments
Patch (12.10 KB, patch)
2019-02-05 15:42 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (60.46 KB, patch)
2019-02-06 16:57 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.17 KB, patch)
2019-02-07 10:37 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-02-05 15:42:54 PST
Created attachment 361232 [details] Patch
EWS Watchlist
Comment 2 2019-02-05 15:46:47 PST
Attachment 361232 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:214: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Radar WebKit Bug Importer
Comment 3 2019-02-05 16:20:39 PST
<rdar://problem/47836112>
youenn fablet
Comment 4 2019-02-06 16:57:15 PST
Created attachment 361347 [details] Patch
EWS Watchlist
Comment 5 2019-02-06 17:00:05 PST
Attachment 361347 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:214: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 6 2019-02-07 10:37:44 PST
Created attachment 361412 [details] Patch for landing
EWS Watchlist
Comment 7 2019-02-07 10:40:18 PST
Attachment 361412 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:214: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 8 2019-02-07 11:20:21 PST
Comment on attachment 361412 [details] Patch for landing Clearing flags on attachment: 361412 Committed r241132: <https://trac.webkit.org/changeset/241132>
WebKit Commit Bot
Comment 9 2019-02-07 11:20:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.