Bug 194288

Summary: [GTK][WPE] force libpsl build to use ICU in jhbuild
Product: WebKit Reporter: Olivier Blin <olivier.blin>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, aperez, bugs-noreply, cgarcia, clopez, commit-queue, ews-watchlist, ltilve, mcatanzaro, pnormand, webkit-bug-importer, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Olivier Blin
Reported 2019-02-05 08:45:09 PST
In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU. This can cause build failures if libidn is detected but libunistring is not available. Make sure that ICU is used for runtime and builtin PSL data.
Attachments
Patch (2.08 KB, patch)
2019-02-05 08:47 PST, Olivier Blin 		no flags
DetailsFormatted DiffDiff
Patch (1.23 KB, patch)
2019-02-06 05:09 PST, Olivier Blin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Olivier Blin
Comment 1 2019-02-05 08:47:44 PST
Created attachment 361193 [details] Patch
WebKit Commit Bot
Comment 2 2019-02-05 12:28:53 PST
Comment on attachment 361193 [details] Patch Clearing flags on attachment: 361193 Committed r240987: <https://trac.webkit.org/changeset/240987>
WebKit Commit Bot
Comment 3 2019-02-05 12:28:55 PST
All reviewed patches have been landed. Closing bug.
Carlos Garcia Campos
Comment 4 2019-02-05 23:42:21 PST
Comment on attachment 361193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361193&action=review > Tools/gtk/jhbuild.modules:234 > <branch module="rockdaboot/libpsl/releases/download/libpsl-${version}/libpsl-${version}.tar.gz" We should add icu as a dependency here like we do in WPE to ensure it's built before. Could you do it in a follow up patch, please? rs=me
Olivier Blin
Comment 5 2019-02-06 05:09:24 PST
Reopening to attach new patch.
Olivier Blin
Comment 6 2019-02-06 05:09:26 PST
Created attachment 361290 [details] Patch
WebKit Commit Bot
Comment 7 2019-02-06 05:47:56 PST
Comment on attachment 361290 [details] Patch Clearing flags on attachment: 361290 Committed r241016: <https://trac.webkit.org/changeset/241016>
WebKit Commit Bot
Comment 8 2019-02-06 05:47:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.