Bug 194269

Summary:

[LFC][IFC] collectInlineContent should use pre-computed margins, paddings and borders

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2019-02-04 19:10:08 PST

This is in preparation for using the same code patch by the preferred width computation (currently broken).

Comment 1 zalan 2019-02-04 19:20:34 PST

Created attachment 361151 [details]
Patch

Comment 2 Antti Koivisto 2019-02-05 07:30:53 PST

Comment on attachment 361151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361151&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:158
> -    unsigned m_baseTypeFlags : 4;
> +    unsigned m_baseTypeFlags : 5;

OptionSet would avoid these problems too!

Comment 3 WebKit Commit Bot 2019-02-05 08:01:35 PST

Comment on attachment 361151 [details]
Patch

Clearing flags on attachment: 361151

Committed r240975: <https://trac.webkit.org/changeset/240975>

Comment 4 WebKit Commit Bot 2019-02-05 08:01:37 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-02-05 08:02:40 PST

<rdar://problem/47818132>