Bug 19426

Summary:

LOW_BANDWIDTH_DISPLAY build broken

Product:

WebKit

Reporter:

David Krause <david.krause>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hyatt

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	darin: review+

Description David Krause 2008-06-06 21:22:46 PDT

Using a recent nightly (r34342), it seems that the build will not finish if USE(LOW_BANDWIDTH_DISPLAY) is set.  WebCore/loader/FrameLoader.cpp fails to compile because of 3 lines of code that look like:

    cache->ref(this);
or:
    (*it)->deref(this);

Looking back, it appears that the changes on changeset 31834 may have introduced this breakage.

The build at least completes if I change ref to addClient and deref to removeClient.

Can an expert confirm this?  If so, I'll submit a patch changing this.

Comment 1 David Krause 2008-06-08 20:04:11 PDT

Created attachment 21587 [details]
Proposed patch

Proposed patch uploaded that changes the three references causing the build to break.

Comment 2 Darin Adler 2008-06-08 20:07:18 PDT

Comment on attachment 21587 [details]
Proposed patch

r=me

Comment 3 Mark Rowe (bdash) 2008-06-22 18:03:11 PDT

Landed in r34733.