Bug 194224

Summary: Protect globalWebSocketStreamMap with a Lock
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Alex Christensen
Reported 2019-02-04 10:13:18 PST
Protect globalWebSocketStreamMap with a Lock
Attachments
Patch (3.14 KB, patch)
2019-02-04 10:13 PST, Alex Christensen 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-02-04 10:13:33 PST
Created attachment 361069 [details] Patch
Alex Christensen
Comment 2 2019-02-04 10:13:35 PST
<rdar://problem/47581081>
Ryosuke Niwa
Comment 3 2019-02-04 14:39:28 PST
Comment on attachment 361069 [details] Patch Do we know which thread/function may end up accessing globalWebSocketStreamMap()? Can we mention that in the change log if so? Otherwise, can we mention that it's a speculative fix?
Alex Christensen
Comment 4 2019-02-04 14:54:21 PST
I think this is related to WebSocket use from workers. I can put such in the ChangeLog after review.
Ryosuke Niwa
Comment 5 2019-02-04 16:33:06 PST
Comment on attachment 361069 [details] Patch Okay, let's hope the rest of the code is thread safe.
Alex Christensen
Comment 6 2019-02-05 07:38:36 PST
http://trac.webkit.org/r240974
Note You need to log in before you can comment on or make changes to this bug.