Bug 194217

Summary: Use a dedicated type instead of int32_t for pointer identifiers
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2019-02-04 06:40:06 PST
Use a dedicated type instead of int32_t for pointer identifiers
Attachments
Patch (17.82 KB, patch)
2019-02-04 06:40 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.82 KB, patch)
2019-02-04 07:53 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2019-02-04 06:40:47 PST
Created attachment 361052 [details] Patch
Antti Koivisto
Comment 2 2019-02-04 07:28:39 PST
Comment on attachment 361052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361052&action=review > Source/WebCore/dom/PointerID.h:32 > +typedef int32_t PointerID; Using 'using' would be more modern: using PointerID = int32_t;
Antoine Quint
Comment 3 2019-02-04 07:53:37 PST
Created attachment 361055 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-02-04 08:22:55 PST
Comment on attachment 361055 [details] Patch for landing Clearing flags on attachment: 361055 Committed r240927: <https://trac.webkit.org/changeset/240927>
WebKit Commit Bot
Comment 5 2019-02-04 08:22:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-02-04 08:23:28 PST
<rdar://problem/47786532>
Note You need to log in before you can comment on or make changes to this bug.