Bug 194217 - Use a dedicated type instead of int32_t for pointer identifiers
Summary: Use a dedicated type instead of int32_t for pointer identifiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-04 06:40 PST by Antoine Quint
Modified: 2019-02-04 08:23 PST (History)
8 users (show)

See Also:


Attachments
Patch (17.82 KB, patch)
2019-02-04 06:40 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (17.82 KB, patch)
2019-02-04 07:53 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-02-04 06:40:06 PST
Use a dedicated type instead of int32_t for pointer identifiers
Comment 1 Antoine Quint 2019-02-04 06:40:47 PST
Created attachment 361052 [details]
Patch
Comment 2 Antti Koivisto 2019-02-04 07:28:39 PST
Comment on attachment 361052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361052&action=review

> Source/WebCore/dom/PointerID.h:32
> +typedef int32_t PointerID;

Using 'using' would be more modern:

using PointerID = int32_t;
Comment 3 Antoine Quint 2019-02-04 07:53:37 PST
Created attachment 361055 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-02-04 08:22:55 PST
Comment on attachment 361055 [details]
Patch for landing

Clearing flags on attachment: 361055

Committed r240927: <https://trac.webkit.org/changeset/240927>
Comment 5 WebKit Commit Bot 2019-02-04 08:22:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-04 08:23:28 PST
<rdar://problem/47786532>