Bug 194209

Summary: REGRESSION(r240785): [SOUP] Broke cookie persistent storage
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, commit-queue, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 194075    
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2019-02-03 19:48:05 PST
I broke cookie persistent storage in r240785 and should probably fix it.
Attachments
Patch (6.60 KB, patch)
2019-02-05 12:02 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-02-04 00:09:11 PST
Should probably fix it?
Michael Catanzaro
Comment 2 2019-02-04 07:05:14 PST
Yes, probably, unless we want all cookies to be lost at the end of the session. :) Seriously now, I made the mistake of assuming TestWebKitCookieManager would notice if I broke cookies. We should probably check somewhere that the persistent storage file is created.
Michael Catanzaro
Comment 3 2019-02-05 12:02:44 PST
Created attachment 361207 [details] Patch
WebKit Commit Bot
Comment 4 2019-02-06 00:06:02 PST
Comment on attachment 361207 [details] Patch Clearing flags on attachment: 361207 Committed r241013: <https://trac.webkit.org/changeset/241013>
WebKit Commit Bot
Comment 5 2019-02-06 00:06:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.