Bug 194181

Summary: Make sure to remove the device observer in AVVideoCaptureSource
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2019-02-01 17:33:42 PST
Make sure to remove the device observer in AVVideoCaptureSource
Attachments
Patch (3.24 KB, patch)
2019-02-01 17:36 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2019-02-01 17:46 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (5.03 KB, patch)
2019-02-04 09:57 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-02-01 17:34:05 PST
<rdar://problem/47739247>
youenn fablet
Comment 2 2019-02-01 17:36:40 PST
Created attachment 360929 [details] Patch
youenn fablet
Comment 3 2019-02-01 17:46:54 PST
Created attachment 360934 [details] Patch
Eric Carlson
Comment 4 2019-02-01 19:19:10 PST
Comment on attachment 360934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360934&action=review r=me > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:206 > +{ Might be worth ASSERTing !m_session? > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:213 > + [m_session removeObserver:m_objcObserver.get() forKeyPath:@"running"]; Might be worth ASSERTing m_session?
youenn fablet
Comment 5 2019-02-04 09:57:48 PST
Created attachment 361066 [details] Patch
WebKit Commit Bot
Comment 6 2019-02-04 10:47:28 PST
Comment on attachment 361066 [details] Patch Clearing flags on attachment: 361066 Committed r240930: <https://trac.webkit.org/changeset/240930>
WebKit Commit Bot
Comment 7 2019-02-04 10:47:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.