Bug 194167

Summary: [JSC] Unify CodeBlock IsoSubspaces
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193606    
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2019-02-01 11:08:12 PST
[JSC] Unify CodeBlock IsoSubspaces
Attachments
Patch (16.68 KB, patch)
2019-02-01 11:50 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-02-01 11:50:09 PST
Created attachment 360881 [details] Patch
Saam Barati
Comment 2 2019-02-01 11:54:38 PST
Comment on attachment 360881 [details] Patch r=me
Saam Barati
Comment 3 2019-02-01 11:55:18 PST
Comment on attachment 360881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360881&action=review > Source/JavaScriptCore/interpreter/Interpreter.cpp:1047 > + UnlinkedEvalCodeBlock* unlinkedCodeBlock = jsDynamicCast<UnlinkedEvalCodeBlock*>(vm, codeBlock->unlinkedCodeBlock()); Why not just codeBlock->unlinkedEvalCodeBlock()?
Yusuke Suzuki
Comment 4 2019-02-01 13:09:55 PST
Comment on attachment 360881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360881&action=review >> Source/JavaScriptCore/interpreter/Interpreter.cpp:1047 >> + UnlinkedEvalCodeBlock* unlinkedCodeBlock = jsDynamicCast<UnlinkedEvalCodeBlock*>(vm, codeBlock->unlinkedCodeBlock()); > > Why not just codeBlock->unlinkedEvalCodeBlock()? It sound OK. Fixed.
Yusuke Suzuki
Comment 5 2019-02-01 13:14:38 PST
Committed r240864: <https://trac.webkit.org/changeset/240864>
Radar WebKit Bug Importer
Comment 6 2019-02-01 13:15:28 PST
<rdar://problem/47746857>
Note You need to log in before you can comment on or make changes to this bug.