Bug 194140

Summary:

[iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit2

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, cdumez, commit-queue, ews-watchlist, rniwa, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none

Description Wenson Hsieh 2019-01-31 22:11:31 PST

To reproduce:

1. Go to https://whsieh.github.io/examples/alert
2. Tap on either button

Expected: modal UI should pop up immediately
Observed: 1 second hang before showing modal UI

Comment 1 Radar WebKit Bug Importer 2019-01-31 22:13:04 PST

<rdar://problem/47728098>

Comment 2 Wenson Hsieh 2019-01-31 22:16:35 PST Comment hidden (obsolete)

Created attachment 360832 [details]
WIP

Comment 3 EWS Watchlist 2019-01-31 23:37:26 PST Comment hidden (obsolete)

Comment on attachment 360832 [details]
WIP

Attachment 360832 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10988074

New failing tests:
fast/frames/frame-dead-region.html
pointer-lock/lock-lost-on-alert.html

Comment 4 EWS Watchlist 2019-01-31 23:37:28 PST Comment hidden (obsolete)

Created attachment 360843 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

Comment 5 Wenson Hsieh 2019-02-01 10:30:04 PST Comment hidden (obsolete)

Created attachment 360871 [details]
Patch

Comment 6 Tim Horton 2019-02-01 11:53:38 PST

Comment on attachment 360871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360871&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:740
> +        m_page.cancelGesturesBlockedOnSynchronousReplies();

Do the thing we talked about on IRC (sendSyncWithDelayedReply)

Comment 7 EWS Watchlist 2019-02-01 12:30:18 PST Comment hidden (obsolete)

Comment on attachment 360871 [details]
Patch

Attachment 360871 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10996414

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall.https.html

Comment 8 EWS Watchlist 2019-02-01 12:30:19 PST Comment hidden (obsolete)

Created attachment 360884 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

Comment 9 Wenson Hsieh 2019-02-01 13:32:29 PST

Created attachment 360892 [details]
Patch

Comment 10 Tim Horton 2019-02-01 14:12:30 PST

Comment on attachment 360892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360892&action=review

> Tools/WebKitTestRunner/TestController.cpp:334
> +        runJavaScriptAlert,

How did we not have this!

Comment 11 WebKit Commit Bot 2019-02-01 15:12:20 PST

Comment on attachment 360892 [details]
Patch

Clearing flags on attachment: 360892

Committed r240882: <https://trac.webkit.org/changeset/240882>

Comment 12 WebKit Commit Bot 2019-02-01 15:12:21 PST

All reviewed patches have been landed.  Closing bug.