Bug 194140

Summary:

[iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit2

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, cdumez, commit-queue, ews-watchlist, rniwa, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none

Wenson Hsieh

Reported 2019-01-31 22:11:31 PST

To reproduce: 1. Go to https://whsieh.github.io/examples/alert 2. Tap on either button Expected: modal UI should pop up immediately Observed: 1 second hang before showing modal UI

Attachments
WIP (29.07 KB, patch) 2019-01-31 22:16 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.59 MB, application/zip) 2019-01-31 23:37 PST, EWS Watchlist	no flags	Details
Patch (40.28 KB, patch) 2019-02-01 10:30 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.45 MB, application/zip) 2019-02-01 12:30 PST, EWS Watchlist	no flags	Details
Patch (42.94 KB, patch) 2019-02-01 13:32 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-01-31 22:13:04 PST

<rdar://problem/47728098>

Wenson Hsieh

Comment 2 2019-01-31 22:16:35 PST Comment hidden (obsolete)

Created attachment 360832 [details] WIP

EWS Watchlist

Comment 3 2019-01-31 23:37:26 PST Comment hidden (obsolete)

Comment on attachment 360832 [details] WIP Attachment 360832 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10988074 New failing tests: fast/frames/frame-dead-region.html pointer-lock/lock-lost-on-alert.html

EWS Watchlist

Comment 4 2019-01-31 23:37:28 PST Comment hidden (obsolete)

Created attachment 360843 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Wenson Hsieh

Comment 5 2019-02-01 10:30:04 PST Comment hidden (obsolete)

Created attachment 360871 [details] Patch

Tim Horton

Comment 6 2019-02-01 11:53:38 PST

Comment on attachment 360871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360871&action=review > Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:740 > + m_page.cancelGesturesBlockedOnSynchronousReplies(); Do the thing we talked about on IRC (sendSyncWithDelayedReply)

EWS Watchlist

Comment 7 2019-02-01 12:30:18 PST Comment hidden (obsolete)

Comment on attachment 360871 [details] Patch Attachment 360871 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10996414 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall.https.html

EWS Watchlist

Comment 8 2019-02-01 12:30:19 PST Comment hidden (obsolete)

Created attachment 360884 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Wenson Hsieh

Comment 9 2019-02-01 13:32:29 PST

Created attachment 360892 [details] Patch

Tim Horton

Comment 10 2019-02-01 14:12:30 PST

Comment on attachment 360892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360892&action=review > Tools/WebKitTestRunner/TestController.cpp:334 > + runJavaScriptAlert, How did we not have this!

WebKit Commit Bot

Comment 11 2019-02-01 15:12:20 PST

Comment on attachment 360892 [details] Patch Clearing flags on attachment: 360892 Committed r240882: <https://trac.webkit.org/changeset/240882>

WebKit Commit Bot

Comment 12 2019-02-01 15:12:21 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.