Bug 194133

Summary:

run-webkit-tests emits message "...running None" when running tests

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=193857

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2019-01-31 18:30:57 PST

Noticed from the output in bug 193857, comment 0, paraphrasing: [[ [[ $ Tools/Scripts/run-webkit-tests --no-build --debug --ios-simulator LayoutTests/fast/events/ios/keypress-keys-in-non-editable-element.html Using port 'ios-simulator' Test configuration: <, x86_64, debug> Placing test results in /Volumes/.../Debug-iphonesimulator/layout-test-results Using Debug build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /Volumes/.../Debug-iphonesimulator/WebKitTestRunnerApp.app - --lint-test-files warnings: LayoutTests/platform/ios/TestExpectations:12 Path does not exist. media/controls/ipad --lint-test-files warnings: LayoutTests/platform/ios/TestExpectations:12 Path does not exist. media/controls/ipad Found 1 test; running 1, skipping 0. Verbose baseline search path: platform/ipad-(6th generation)-...-wk2 -> platform/ipad-(6th generation)-... -> platform/ipad-(6th generation)-simulator-wk2 -> platform/ipad-(6th generation)-simulator -> platform/ipad-...-wk2 -> platform/ipad-... -> platform/ipad-simulator-wk2 -> platform/ipad-simulator -> platform/ios-...-wk2 -> platform/ios-... -> platform/ios-simulator-wk2 -> platform/ios-simulator -> platform/ipad-(6th generation)-...-wk2 -> platform/ipad-(6th generation)-... -> platform/ipad-(6th generation)-wk2 -> platform/ipad-(6th generation) -> platform/ipad-...-wk2 -> platform/ipad-... -> platform/ipad-wk2 -> platform/ipad -> platform/ios-...-wk2 -> platform/ios-... -> platform/ios-wk2 -> platform/ios -> platform/wk2 -> generic Baseline search path: platform/ios-simulator-wk2 -> platform/ios-simulator -> platform/ipad -> platform/ios-wk2 -> platform/ios -> platform/wk2 -> generic Running 1 test for iPad (6th generation) running None Running 1 WebKitTestRunnerApp.app. [1/1] fast/events/ios/keypress-keys-in-non-editable-element.html failed unexpectedly (text diff) Retrying 1 unexpected failure ... Running 1 WebKitTestRunnerApp.app. ]] Notice the "Running 1 test for iPad (6th generation) running None" line. Specifically, the "... running None" part of the line. What does this mean? Doesn't read right.

Attachments
Patch (3.41 KB, patch) 2019-02-05 09:12 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-01-31 18:31:44 PST

<rdar://problem/47724738>

Radar WebKit Bug Importer

Comment 2 2019-01-31 18:31:46 PST

<rdar://problem/47724739>

Jonathan Bedard

Comment 3 2019-02-01 08:40:01 PST

I agree that the 'running None' is silly (it should be running iOS <version>). I've seen this effect on-device testing as well. It's most likely a failure to define the OS when picking up booted devices.

Jonathan Bedard

Comment 4 2019-02-05 09:03:56 PST

Actually, looks like this is really about problems with future versions. It's a pretty simple fix.

Jonathan Bedard

Comment 5 2019-02-05 09:12:18 PST

Created attachment 361195 [details] Patch

WebKit Commit Bot

Comment 6 2019-02-05 10:33:46 PST

Comment on attachment 361195 [details] Patch Clearing flags on attachment: 361195 Committed r240982: <https://trac.webkit.org/changeset/240982>

WebKit Commit Bot

Comment 7 2019-02-05 10:33:48 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.