Bug 194130

Summary: Remove invalid assertion in DFG's compileDoubleRep().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
saam: review+, ews-watchlist: commit-queue-
patch for landing. none

Mark Lam
Reported 2019-01-31 17:21:41 PST
Also remove an invalid assertion in DFG's compileDoubleRep(). <rdar://problem/47699474>
Attachments
proposed patch. (3.48 KB, patch)
2019-01-31 17:30 PST, Mark Lam 		saam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
patch for landing. (2.74 KB, patch)
2019-02-01 11:27 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-01-31 17:30:53 PST
Created attachment 360815 [details] proposed patch.
Saam Barati
Comment 2 2019-01-31 17:47:32 PST
Comment on attachment 360815 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=360815&action=review > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:793 > + m_graph.convertToConstant(node, JSValue(node->child1()->asNumber())); do we need purifyNaN here?
Saam Barati
Comment 3 2019-01-31 17:56:01 PST
Comment on attachment 360815 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=360815&action=review > Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:792 > + if (node->child1()->isNumberConstant()) { You should put this in AI.
Saam Barati
Comment 4 2019-01-31 17:59:03 PST
Comment on attachment 360815 [details] proposed patch. r=me to remove the assert. It's worth figuring out why the already present rule in AI isn't working.
EWS Watchlist
Comment 5 2019-01-31 21:07:07 PST
Comment on attachment 360815 [details] proposed patch. Attachment 360815 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/10985070 New failing tests: stress/op_add.js.misc-ftl-no-cjit stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager-no-cjit apiTests
Mark Lam
Comment 6 2019-02-01 10:58:51 PST
(In reply to Saam Barati from comment #4) > Comment on attachment 360815 [details] > proposed patch. > > r=me to remove the assert. It's worth figuring out why the already present > rule in AI isn't working. OK, I'm just going to remove the assertion in this patch. Will look into the DoubleRep constant folding issue in https://bugs.webkit.org/show_bug.cgi?id=194165.
Mark Lam
Comment 7 2019-02-01 11:27:41 PST
Created attachment 360877 [details] patch for landing.
WebKit Commit Bot
Comment 8 2019-02-01 14:47:25 PST
Comment on attachment 360877 [details] patch for landing. Clearing flags on attachment: 360877 Committed r240878: <https://trac.webkit.org/changeset/240878>
WebKit Commit Bot
Comment 9 2019-02-01 14:47:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.