Bug 194124 – Enable the automatic checking and regenerations of .xcfilelists during builds

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Keith Rollin]

Bug 193790 add a facility for checking -- during build time -- that any needed .xcfilelist files are up-to-date and for updating them if they are not. This facility was initially opt-in by setting WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until the process seemed robust. Its now time to enable this facility and make it opt-out. If there is a need to disable this facility, set and export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before running `make` or `build-webkit`, or before running Xcode from the command line.

[Radar WebKit Bug Importer]

<rdar://problem/47721277>

[Keith Rollin]

Created attachment 360807 [details]
Patch

[Keith Rollin]

EWS isn't catching a problem. This patch should not be passing -- the build should be failing because Bug 194121 is not yet landed and so the .xcfilelists are out-of-date. Enabling this patch should be catching that. It looks like incremental rebuilds are not triggering the checking facility if nothing else has changed.

After Bug 194121 lands, I'm going to re-upload this patch. The new patch will include any last-minute changes to the .xcfilelists. I'll also see if I can put in place a dependency that will cause the "Check .xcfilelists" phase to run if any check-xcfilelists.sh script changes.

[Keith Rollin]

(In reply to Keith Rollin from comment #3)
> EWS isn't catching a problem. This patch should not be passing -- the build
> should be failing because Bug 194121 is not yet landed and so the
> .xcfilelists are out-of-date. Enabling this patch should be catching that.
> It looks like incremental rebuilds are not triggering the checking facility
> if nothing else has changed.
> 
> After Bug 194121 lands, I'm going to re-upload this patch. The new patch
> will include any last-minute changes to the .xcfilelists. I'll also see if I
> can put in place a dependency that will cause the "Check .xcfilelists" phase
> to run if any check-xcfilelists.sh script changes.

Wait a second. The patch originally uploaded should have been fine. The "check xcfilelists" phase has no stated dependencies, which should cause it to execute unconditionally. I've verified locally that it does this. I don't know why it wouldn't do that on EWS.

[Keith Rollin]

Created attachment 361098 [details]
Patch

[Keith Rollin]

Tim Horton pointed out that specifying all source files participating in the UnifieSources facility is unnecessary. We only need to specify Sources.txt and SourcesCocoa.txt. Uploading a patch that reflects that.

[Keith Rollin]

Created attachment 361216 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 361216 [details]
Patch

Clearing flags on attachment: 361216

Committed r240994: <https://trac.webkit.org/changeset/240994>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Keith Rollin]

*** Bug 193834 has been marked as a duplicate of this bug. ***