Bug 193790 - Update Xcode projects with "Check .xcfilelists" build phase
Summary: Update Xcode projects with "Check .xcfilelists" build phase
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-01-24 15:37 PST by Keith Rollin
Modified: 2019-01-25 15:52 PST (History)
11 users (show)

See Also:

Patch (18.61 KB, patch)
2019-01-25 15:24 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-01-24 15:37:21 PST
Support for XCBuild includes specifying inputs and outputs to various Run Script build phases. These inputs and outputs are specified as .xcfilelist files. Once created, these .xcfilelist files need to be kept up-to-date. In order to check that they are up-to-date or not, add an Xcode build step that invokes an external script that performs the checking. If the .xcfilelists are found to be out-of-date, update them, halt the build, and instruct the developer to restart the build with up-to-date files.

At this time, the checking and regenerating is performed only if the WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People who want to use this facility can set this variable and test out the checking/regenerating. Once it seems like there are no egregious issues that upset a developer's workflow, we'll unconditionally enable this facility.
Comment 1 Keith Rollin 2019-01-24 15:39:12 PST
Comment 2 Keith Rollin 2019-01-25 15:24:07 PST
Created attachment 360175 [details]
Comment 3 WebKit Commit Bot 2019-01-25 15:52:57 PST
Comment on attachment 360175 [details]

Clearing flags on attachment: 360175

Committed r240525: <https://trac.webkit.org/changeset/240525>
Comment 4 WebKit Commit Bot 2019-01-25 15:52:59 PST
All reviewed patches have been landed.  Closing bug.