Bug 194113

Summary: Remove poisoning from CodeBlock and LLInt code.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
ysuzuki: review+
patch for landing. none

Mark Lam
Reported 2019-01-31 14:17:33 PST
Poisoning is no longer needed.
Attachments
proposed patch. (19.56 KB, patch)
2019-01-31 14:21 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing. (23.50 KB, patch)
2019-01-31 15:10 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-01-31 14:21:23 PST
Created attachment 360781 [details] proposed patch.
EWS Watchlist
Comment 2 2019-01-31 14:25:03 PST
Attachment 360781 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2019-01-31 14:37:31 PST
Comment on attachment 360781 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=360781&action=review r=me with some suggestions. > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:535 > + loadp CodeBlock::m_vm[scratch], scratch scratch2 is no longer necessary. > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:-1037 > - unpoison(_g_JSFunctionPoison, targetRegister, scratch) scratch is no longer necessary. > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:-1049 > - unpoison(_g_JSFunctionPoison, targetRegister, scratch) Ditto.
Mark Lam
Comment 4 2019-01-31 15:10:14 PST
Created attachment 360793 [details] patch for landing. Thanks for the feedback. I've removed the unneeded scratch registers.
EWS Watchlist
Comment 5 2019-01-31 15:13:01 PST
Attachment 360793 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 6 2019-01-31 17:38:26 PST
Landed in r240832: <http://trac.webkit.org/r240832>.
Radar WebKit Bug Importer
Comment 7 2019-01-31 17:39:29 PST
<rdar://problem/47723400>
Note You need to log in before you can comment on or make changes to this bug.