| Summary: | Remove poisoning from CodeBlock and LLInt code. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2019-01-31 14:17:33 PST
Created attachment 360781 [details]
proposed patch.
Attachment 360781 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 360781 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=360781&action=review r=me with some suggestions. > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:535 > + loadp CodeBlock::m_vm[scratch], scratch scratch2 is no longer necessary. > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:-1037 > - unpoison(_g_JSFunctionPoison, targetRegister, scratch) scratch is no longer necessary. > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:-1049 > - unpoison(_g_JSFunctionPoison, targetRegister, scratch) Ditto. Created attachment 360793 [details]
patch for landing.
Thanks for the feedback. I've removed the unneeded scratch registers.
Attachment 360793 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Landed in r240832: <http://trac.webkit.org/r240832>. |