| Summary: | Generalize ScrollingTreeScrollingNodeDelegate for use in macOS too, add a macOS subclass for frame/overflow scrolling | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, simon.fraser, tonikitoo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 172917 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2019-01-30 22:33:02 PST
Created attachment 360693 [details]
Patch
Probably won't build without the patch from bug 172917. Comment on attachment 360693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360693&action=review > Source/WebCore/ChangeLog:12 > + Add a macOS subclass, ScrollingTreeFrameScrollingNodeMac, which takes over the basic scrolling, rubber-banding > + and scroll snapping functionality from ScrollingTreeFrameScrollingNodeMac. The delegate owns the ScrollController and ScrollingTreeFrameScrollingNodeMac is probably not taking over from itself Created attachment 360729 [details]
Patch
|