| Summary: | Don't insert spaces at the beginning of a newline when using smart-copy-paste | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> |
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, rniwa, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
Megan Gardner
2019-01-30 18:03:25 PST
Created attachment 360663 [details]
Patch
Comment on attachment 360663 [details] Patch Attachment 360663 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10961812 New failing tests: editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html Created attachment 360670 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 360663 [details] Patch Attachment 360663 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10962234 New failing tests: editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html Created attachment 360678 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 360663 [details] Patch Attachment 360663 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10962200 New failing tests: editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html Created attachment 360680 [details]
Archive of layout-test-results from ews113 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 360663 [details] Patch Attachment 360663 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10962513 New failing tests: editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html Created attachment 360682 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 360683 [details]
Patch
Comment on attachment 360683 [details] Patch Attachment 360683 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10964447 New failing tests: editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html Created attachment 360692 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 360735 [details]
Patch
Comment on attachment 360735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360735&action=review > Source/WebCore/ChangeLog:9 > + Also, if our inserted content beginning is at the end of a paragar, do not instert a space. PARAGAR INSTERT > LayoutTests/ChangeLog:7 > + Rebaseline a test the is dependant on a console log that changes lines. "the is" > LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt:1 > -CONSOLE MESSAGE: line 88: The download attribute on anchor was ignored because its href URL has a different security origin. > +CONSOLE MESSAGE: line 107: The download attribute on anchor was ignored because its href URL has a different security origin. :| > LayoutTests/resources/ui-helper.js:135 > + // only here to deal with async/sync copy/paste calls. > + // once <rdar://problem/16207002> is resolved, should be able to remove for faster tests. Capitals, whole sentences, etc. Created attachment 360799 [details]
Patch for landing
Comment on attachment 360799 [details] Patch for landing Clearing flags on attachment: 360799 Committed r240829: <https://trac.webkit.org/changeset/240829> All reviewed patches have been landed. Closing bug. |