Bug 194067

Summary: [MSE][GStreamer] Remove unused GstFlowReturn in AppendPipeline methods
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2019-01-30 17:16:12 PST
A couple methods in AppendPipeline were returning GstFlowReturn despite there being no codepath (sans assertions) where values other than GST_FLOW_OK are returned. Therefore, it makes sense to just make these methods return void.
Attachments
Patch (8.23 KB, patch)
2019-01-30 17:17 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2019-01-30 17:17:17 PST
Created attachment 360656 [details] Patch
WebKit Commit Bot
Comment 2 2019-01-31 06:54:57 PST
Comment on attachment 360656 [details] Patch Clearing flags on attachment: 360656 Committed r240784: <https://trac.webkit.org/changeset/240784>
WebKit Commit Bot
Comment 3 2019-01-31 06:54:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.