Bug 194067 - [MSE][GStreamer] Remove unused GstFlowReturn in AppendPipeline methods
Summary: [MSE][GStreamer] Remove unused GstFlowReturn in AppendPipeline methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-30 17:16 PST by Alicia Boya García
Modified: 2019-02-05 08:03 PST (History)
4 users (show)

See Also:


Attachments
Patch (8.23 KB, patch)
2019-01-30 17:17 PST, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2019-01-30 17:16:12 PST
A couple methods in AppendPipeline were returning GstFlowReturn
despite there being no codepath (sans assertions) where values other
than GST_FLOW_OK are returned.

Therefore, it makes sense to just make these methods return void.
Comment 1 Alicia Boya García 2019-01-30 17:17:17 PST
Created attachment 360656 [details]
Patch
Comment 2 WebKit Commit Bot 2019-01-31 06:54:57 PST
Comment on attachment 360656 [details]
Patch

Clearing flags on attachment: 360656

Committed r240784: <https://trac.webkit.org/changeset/240784>
Comment 3 WebKit Commit Bot 2019-01-31 06:54:59 PST
All reviewed patches have been landed.  Closing bug.