WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
194067
[MSE][GStreamer] Remove unused GstFlowReturn in AppendPipeline methods
https://bugs.webkit.org/show_bug.cgi?id=194067
Summary
[MSE][GStreamer] Remove unused GstFlowReturn in AppendPipeline methods
Alicia Boya García
Reported
2019-01-30 17:16:12 PST
A couple methods in AppendPipeline were returning GstFlowReturn despite there being no codepath (sans assertions) where values other than GST_FLOW_OK are returned. Therefore, it makes sense to just make these methods return void.
Attachments
Patch
(8.23 KB, patch)
2019-01-30 17:17 PST
,
Alicia Boya García
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alicia Boya García
Comment 1
2019-01-30 17:17:17 PST
Created
attachment 360656
[details]
Patch
WebKit Commit Bot
Comment 2
2019-01-31 06:54:57 PST
Comment on
attachment 360656
[details]
Patch Clearing flags on attachment: 360656 Committed
r240784
: <
https://trac.webkit.org/changeset/240784
>
WebKit Commit Bot
Comment 3
2019-01-31 06:54:59 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug