Bug 194058

Summary: Add default constructor for NetworkActivityTracker
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Rollin
Reported 2019-01-30 16:03:10 PST
ResourceNetworkActivityTracker has a default constructor. It also has a NetworkActivityTracker data member, which does not have a default constructor. This will cause some compilers to complain -- they can't default-create a ResourceNetworkActivityTracker because they can't default-create its data members. Address this by adding a default constructor for NetworkActivityTracker.
Attachments
Patch (1.88 KB, patch)
2019-01-30 16:05 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2019-01-30 16:32 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-30 16:03:28 PST
<rdar://problem/47685457>
Keith Rollin
Comment 2 2019-01-30 16:05:40 PST
Created attachment 360638 [details] Patch
Chris Dumez
Comment 3 2019-01-30 16:07:49 PST
Comment on attachment 360638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360638&action=review > Source/WebKit/NetworkProcess/NetworkActivityTracker.h:68 > NetworkActivityTracker(Label, Domain = Domain::WebKit); explicit ?
Keith Rollin
Comment 4 2019-01-30 16:32:54 PST
Created attachment 360644 [details] Patch
WebKit Commit Bot
Comment 5 2019-01-30 17:55:33 PST
Comment on attachment 360644 [details] Patch Clearing flags on attachment: 360644 Committed r240747: <https://trac.webkit.org/changeset/240747>
WebKit Commit Bot
Comment 6 2019-01-30 17:55:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.