Bug 194037

Summary: Remove assertion that CachedSymbolTables should have no RareData
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: WebKit2Assignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Tadeu Zagallo
Reported 2019-01-30 13:22:52 PST
It turns out that we don't need to cache the SymbolTableRareData, but we should not assert that it's null.
Attachments
Patch (1.80 KB, patch)
2019-01-30 13:45 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.80 KB, patch)
2019-01-30 14:08 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.80 KB, patch)
2019-01-30 15:03 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-01-30 13:45:59 PST
Created attachment 360612 [details] Patch
Mark Lam
Comment 2 2019-01-30 14:06:39 PST
Comment on attachment 360612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360612&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + It turns out that we don't need to cache the SymbolTableRareData, but > + we should not assert that it's empty. nit: Do you mean 'and we should not assert ..."?
Tadeu Zagallo
Comment 3 2019-01-30 14:08:42 PST
Created attachment 360619 [details] Patch for landing
Tadeu Zagallo
Comment 4 2019-01-30 15:03:50 PST
Created attachment 360629 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-01-30 16:47:04 PST
Comment on attachment 360629 [details] Patch for landing Clearing flags on attachment: 360629 Committed r240739: <https://trac.webkit.org/changeset/240739>
WebKit Commit Bot
Comment 6 2019-01-30 16:47:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-01-30 16:48:38 PST
<rdar://problem/47687176>
Saam Barati
Comment 8 2019-01-30 23:41:48 PST
Comment on attachment 360629 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=360629&action=review > Source/JavaScriptCore/ChangeLog:8 > + It turns out that we don't need to cache the SymbolTableRareData and It’s worth describing why here.
Tadeu Zagallo
Comment 9 2019-02-08 00:55:46 PST
*** Bug 194430 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.