Bug 194015

Summary: [JSC] Make global static variables "const" as much as possible
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193606    
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-01-30 04:53:41 PST
[JSC] Make global static variables "const" as much as possible
Attachments
Patch (9.09 KB, patch)
2019-01-30 04:54 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-01-30 04:54:57 PST
Created attachment 360571 [details] Patch
EWS Watchlist
Comment 2 2019-01-30 04:56:46 PST
Attachment 360571 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generator.py:146: multiple statements on one line (semicolon) [pep8/E702] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2019-01-30 10:11:12 PST
Comment on attachment 360571 [details] Patch r=me
Yusuke Suzuki
Comment 4 2019-01-30 10:53:36 PST
Thanks!
Yusuke Suzuki
Comment 5 2019-01-30 10:55:43 PST
Committed r240718: <https://trac.webkit.org/changeset/240718>
Radar WebKit Bug Importer
Comment 6 2019-01-30 10:57:37 PST
<rdar://problem/47673047>
Yusuke Suzuki
Comment 7 2019-01-30 12:27:56 PST
Committed r240726: <https://trac.webkit.org/changeset/240726>
Note You need to log in before you can comment on or make changes to this bug.