Bug 194015

Summary: [JSC] Make global static variables "const" as much as possible
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193606    
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2019-01-30 04:53:41 PST 
[JSC] Make global static variables "const" as much as possible
Comment 1 Yusuke Suzuki 2019-01-30 04:54:57 PST 
Created attachment 360571 [details]
Patch
Comment 2 EWS Watchlist 2019-01-30 04:56:46 PST 
Attachment 360571 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generator.py:146:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2019-01-30 10:11:12 PST 
Comment on attachment 360571 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2019-01-30 10:53:36 PST 
Thanks!
Comment 5 Yusuke Suzuki 2019-01-30 10:55:43 PST 
Committed r240718: <https://trac.webkit.org/changeset/240718>
Comment 6 Radar WebKit Bug Importer 2019-01-30 10:57:37 PST 
<rdar://problem/47673047>
Comment 7 Yusuke Suzuki 2019-01-30 12:27:56 PST 
Committed r240726: <https://trac.webkit.org/changeset/240726>