Bug 193983

Summary: Web Inspector: Styles: enable computed style cascades by default
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 193986    
Attachments:
Description Flags
Patch
mattbaker: review+
Patch none

Nikita Vasilyev
Reported 2019-01-29 14:24:16 PST
<rdar://problem/47645821>
Attachments
Patch (7.43 KB, patch)
2019-01-29 14:28 PST, Nikita Vasilyev 		mattbaker: review+
DetailsFormatted DiffDiff
Patch (9.99 KB, patch)
2019-01-29 15:04 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2019-01-29 14:28:31 PST
Created attachment 360502 [details] Patch
Nikita Vasilyev
Comment 2 2019-01-29 14:31:43 PST
Note that this patch doesn't remove a lot of the old code. The Variables section is still based on SpreadsheetCSSStyleDeclarationEditor and uses the old computed tab logic.
Matt Baker
Comment 3 2019-01-29 14:33:22 PST
Comment on attachment 360502 [details] Patch rs=me
Devin Rousso
Comment 4 2019-01-29 14:38:59 PST
Comment on attachment 360502 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360502&action=review > Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js:107 > Style: remove this newline. > Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:32 > + this.element.classList.add("computed-with-traces"); Rather than just always adding this class, why not merge the styles?
Nikita Vasilyev
Comment 5 2019-01-29 15:04:25 PST
Created attachment 360504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360502&action=review >> Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:32 >> + this.element.classList.add("computed-with-traces"); > > Rather than just always adding this class, why not merge the styles? Sure, that was actually not that hard!
WebKit Commit Bot
Comment 6 2019-01-29 16:37:06 PST
Comment on attachment 360504 [details] Patch Clearing flags on attachment: 360504 Committed r240691: <https://trac.webkit.org/changeset/240691>
WebKit Commit Bot
Comment 7 2019-01-29 16:37:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.