Bug 193979

Summary:

REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS

Product:

WebKit

Reporter:

Truitt Savell <tsavell>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, jlewis3, lforschler, rniwa, ryanhaddad, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the test	none

Truitt Savell

Reported 2019-01-29 13:38:34 PST

WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing on iOS after being introduced in https://trac.webkit.org/changeset/240541/webkit Failed TestWebKitAPI.WebKit.WebsitePoliciesCustomJavaScriptUserAgent Received data during response processing, queuing it. Received data during response processing, queuing it. Received data during response processing, queuing it. /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true

Attachments
Fixes the test (1.71 KB, patch) 2019-01-30 17:51 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2019-01-30 10:29:49 PST

Ryosuke, can you look into this today, or should the change be rolled back?

Ryosuke Niwa

Comment 2 2019-01-30 17:45:03 PST

Ugh... of course. iOS has a different UA string.

Ryosuke Niwa

Comment 3 2019-01-30 17:51:36 PST

Created attachment 360660 [details] Fixes the test

Ryosuke Niwa

Comment 4 2019-01-30 19:56:20 PST

Comment on attachment 360660 [details] Fixes the test Clearing flags on attachment: 360660 Committed r240756: <https://trac.webkit.org/changeset/240756>

Ryosuke Niwa

Comment 5 2019-01-30 19:56:22 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-01-30 19:57:29 PST

<rdar://problem/47691812>

Note You need to log in before you can comment on or make changes to this bug.