Summary: | [ews-build] Configure buildbot to send events to ews-app | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, ews-watchlist, kocsen_chung, lforschler, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=193928 https://bugs.webkit.org/show_bug.cgi?id=193973 |
||||||
Attachments: |
|
Description
Aakash Jain
2019-01-29 10:49:31 PST
Created attachment 360477 [details]
Proposed patch
Attachment 360477 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:28: No name 'python' in module 'twisted' [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:29: No name 'internet' in module 'twisted' [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:30: No name 'internet' in module 'twisted' [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:31: No name 'web' in module 'twisted' [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:32: No name 'web' in module 'twisted' [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:33: No name 'web' in module 'twisted' [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:35: No name 'internet' in module 'twisted' [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:36: No name 'service' in module 'buildbot.util' [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:111: [Events.buildStarted] Instance of 'Events' has no 'master' member [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:132: [Events.buildFinished] Instance of 'Events' has no 'master' member [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:134: [Events.buildFinished] Instance of 'Events' has no 'master' member [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/events.py:185: [Events.startService] Instance of 'Events' has no 'master' member [pylint/E1101] [5]
Total errors found: 12 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 360477 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=360477&action=review lgtm with a couple comments. > Tools/BuildSlaveSupport/ews-build/events.py:37 > + I forget our sorting policy when using 'from', but TextMate sorts these: from buildbot.util import service from twisted.internet import defer from twisted.internet import reactor from twisted.internet.defer import succeed from twisted.python import log from twisted.web.client import Agent from twisted.web.http_headers import Headers from twisted.web.iweb import IBodyProducer from zope.interface import implements > Tools/BuildSlaveSupport/ews-build/events.py:77 > + def __init__(self, type_prefix="", name='Events'): mixing "" and '' here. > Tools/BuildSlaveSupport/ews-build/events.py:102 > + def getPatchid(self, build): maybe consider getPatch_id ? disregard if we are trying to stay consistent with other uses. > I forget our sorting policy when using 'from', but TextMate sorts these: Done > mixing "" and '' here. Fixed > maybe consider getPatch_id ? renamed to getPatchID Committed r240671: <https://trac.webkit.org/changeset/240671> |