Bug 193965

Summary:

EnableResizeObserver for ResizeObserver test cases when webkit-test-runner

Product:

WebKit

Reporter:

cathiechen <cathiechen>

Component:

DOM

Assignee:

cathiechen <cathiechen>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

cdumez, ews-watchlist, fred.wang

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
To test building error in wincairo	none
To test wincairo build error	none
To test wincairo build error	none
To test wincairo build error	none

Description cathiechen 2019-01-29 08:11:33 PST

EnableResizeObserver for ResizeObserver test cases  when webkit-test-runner

Comment 1 cathiechen 2019-01-29 08:33:19 PST

Created attachment 360461 [details]
Patch

Comment 2 Frédéric Wang (:fredw) 2019-01-30 00:26:27 PST

Comment on attachment 360461 [details]
Patch

I think this should be done when you first introduce the ResizeObserver preference (i.e. for now in your patch for bug 157743).

Comment 3 cathiechen 2019-01-30 05:37:47 PST

(In reply to Frédéric Wang (:fredw) from comment #2)
> Comment on attachment 360461 [details]
> Patch
> 
> I think this should be done when you first introduce the ResizeObserver
> preference (i.e. for now in your patch for bug 157743).

OK, got it. Thanks:)

Comment 4 cathiechen 2019-03-28 10:03:10 PDT

Created attachment 366181 [details]
Patch

Comment 5 cathiechen 2019-03-28 10:06:14 PDT

Created attachment 366182 [details]
Patch

Comment 6 cathiechen 2019-03-28 17:22:51 PDT

Created attachment 366227 [details]
Patch

Comment 7 cathiechen 2019-03-28 20:35:01 PDT

Created attachment 366240 [details]
To test building error in wincairo

Comment 8 cathiechen 2019-03-28 21:46:17 PDT

Created attachment 366246 [details]
To test wincairo build error

Comment 9 cathiechen 2019-03-28 21:53:22 PDT

Created attachment 366247 [details]
To test wincairo build error

Comment 10 EWS Watchlist 2019-03-28 21:55:05 PDT

Attachment 366247 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
Total errors found: 5 in 81 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 cathiechen 2019-03-28 22:14:17 PDT

Created attachment 366249 [details]
To test wincairo build error

Comment 12 cathiechen 2019-03-29 01:22:11 PDT

This has been resolved in bug 157743.

*** This bug has been marked as a duplicate of bug 157743 ***