Bug 193950

Summary: User agent string override for navigator.userAgent should be site specific quirks
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit2Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, cdumez, commit-queue, dbates, ews-watchlist, ggaren, hi, japhet, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193762
Attachments:
Description Flags
Hides behind site specific quirks
none
Removed superflous auto
none
Patch for landing
none
Fixed iOS build none

Ryosuke Niwa
Reported 2019-01-28 19:41:47 PST
In order to make it possible to toggle the UA string override just for navigator.userAgent via Web Inspector, we need to put this behind the site specific quirks.
Attachments
Hides behind site specific quirks (14.62 KB, patch)
2019-01-28 19:49 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Removed superflous auto (14.62 KB, patch)
2019-01-28 20:21 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.90 KB, patch)
2019-01-28 20:50 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed iOS build (14.89 KB, patch)
2019-01-28 21:40 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-01-28 19:49:50 PST
Created attachment 360425 [details] Hides behind site specific quirks
Brent Fulgham
Comment 2 2019-01-28 20:11:52 PST
Comment on attachment 360425 [details] Hides behind site specific quirks View in context: https://bugs.webkit.org/attachment.cgi?id=360425&action=review > Source/WebCore/loader/FrameLoader.cpp:2719 > + auto userAgent = documentLoader->customJavaScriptUserAgentAsSiteSpecificQuirks(); I don't think you want to declare it 'auto' here -- won't it go out of scope after this line?
Ryosuke Niwa
Comment 3 2019-01-28 20:19:53 PST
(In reply to Brent Fulgham from comment #2) > Comment on attachment 360425 [details] > Hides behind site specific quirks > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360425&action=review > > > Source/WebCore/loader/FrameLoader.cpp:2719 > > + auto userAgent = documentLoader->customJavaScriptUserAgentAsSiteSpecificQuirks(); > > I don't think you want to declare it 'auto' here -- won't it go out of scope > after this line? Oh oops, I forgot to remove that auto after moving the code around.
Ryosuke Niwa
Comment 4 2019-01-28 20:21:49 PST
Created attachment 360429 [details] Removed superflous auto
Brent Fulgham
Comment 5 2019-01-28 20:24:23 PST
Comment on attachment 360429 [details] Removed superflous auto r=mews
Ryosuke Niwa
Comment 6 2019-01-28 20:49:24 PST
Oops, I forgot to enable SiteSpecificQuirks in API tests.
Ryosuke Niwa
Comment 7 2019-01-28 20:50:24 PST
Created attachment 360430 [details] Patch for landing
Ryosuke Niwa
Comment 8 2019-01-28 21:00:44 PST
Comment on attachment 360430 [details] Patch for landing Wait for EWS
Ryosuke Niwa
Comment 9 2019-01-28 21:40:55 PST
Created attachment 360437 [details] Fixed iOS build
Ryosuke Niwa
Comment 10 2019-01-28 23:15:02 PST
Committed r240646: <https://trac.webkit.org/changeset/240646>
Radar WebKit Bug Importer
Comment 11 2019-01-28 23:15:40 PST
<rdar://problem/47624338>
Note You need to log in before you can comment on or make changes to this bug.