Bug 193929

Summary: Move platform-specific files out of WTF root directory.
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, don.olmstead, ews-watchlist, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ross Kirsling
Reported 2019-01-28 15:18:56 PST
Move platform-specific files out of WTF root directory.
Attachments
Patch (104.26 KB, patch)
2019-01-28 15:19 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (146.89 KB, patch)
2019-01-28 19:15 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2019-01-28 15:19:41 PST
Created attachment 360384 [details] Patch
EWS Watchlist
Comment 2 2019-01-28 15:23:15 PST
Attachment 360384 [details] did not pass style-queue: ERROR: Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/RunLoopTimerCF.cpp:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/win/ThreadingWin.cpp:88: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/win/ThreadingWin.cpp:116: MS_VC_EXCEPTION is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/win/ThreadingWin.cpp:214: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/win/ThreadingWin.cpp:342: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/win/OSAllocatorWin.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 7 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ross Kirsling
Comment 3 2019-01-28 16:35:40 PST
I'd be happy to move ThreadingPthreads.cpp to posix/ at the same time, but I wonder if the filename should be updated to ThreadingPOSIX.cpp then?
Ross Kirsling
Comment 4 2019-01-28 19:15:46 PST
Created attachment 360419 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-01-28 20:00:15 PST
Comment on attachment 360419 [details] Patch for landing Clearing flags on attachment: 360419 Committed r240636: <https://trac.webkit.org/changeset/240636>
WebKit Commit Bot
Comment 6 2019-01-28 20:00:18 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-01-28 20:01:38 PST
<rdar://problem/47621312>
Note You need to log in before you can comment on or make changes to this bug.