Bug 193928

Summary: [ews-app] Make the results url generic
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193968
https://bugs.webkit.org/show_bug.cgi?id=193973
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2019-01-28 15:16:46 PST
Currently ews-app url to submit results contains patch_id in it. This works for 'build' event result, but not for 'step' event results, since step events results do not contain patch_id. We should make the url to accept result generic, so that it can accept any kind of data. Data verification can be done after receiving and parsing the data.
Attachments
Proposed patch (1.26 KB, patch)
2019-01-28 15:20 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-28 15:20:26 PST
Created attachment 360385 [details] Proposed patch
Lucas Forschler
Comment 2 2019-01-28 15:24:10 PST
Comment on attachment 360385 [details] Proposed patch Do we have existing code currently using the /patch api path? lgtm, as long as this doesn't break anything in place.
Aakash Jain
Comment 3 2019-01-28 15:33:19 PST
> Do we have existing code currently using the /patch api path? lgtm, as long as this doesn't break anything in place. Nothing in production. Next patch coming soon to process the data which comes through /results/ path.
Aakash Jain
Comment 4 2019-01-29 12:12:45 PST
> Next patch coming soon to process the data which comes through /results/ path. https://bugs.webkit.org/show_bug.cgi?id=193973 has patch to handle the results data. https://bugs.webkit.org/show_bug.cgi?id=193968 has patch which starts sending data to this results url.
WebKit Commit Bot
Comment 5 2019-01-29 12:53:23 PST
Comment on attachment 360385 [details] Proposed patch Clearing flags on attachment: 360385 Committed r240673: <https://trac.webkit.org/changeset/240673>
WebKit Commit Bot
Comment 6 2019-01-29 12:53:25 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-01-29 12:54:27 PST
<rdar://problem/47642499>
Note You need to log in before you can comment on or make changes to this bug.