Bug 193927

Summary: [Cocoa] Add SPI to _WKUserContentExtensionStore to retrieve its underlying WKContentRuleListStore
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2019-01-28 15:15:20 PST
[Cocoa] Add SPI to _WKUserContentExtensionStore to retrieve its underlying WKContentRuleListStore
Attachments
Patch (2.35 KB, patch)
2019-01-28 15:24 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2019-01-28 15:42 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2019-01-28 15:24:19 PST
Created attachment 360387 [details] Patch
Tim Horton
Comment 2 2019-01-28 15:28:07 PST
Comment on attachment 360387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360387&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:38 > - (id)_initWithWKContentRuleListStore:(WKContentRuleListStore*)contentRuleListStore WK_API_AVAILABLE(macosx(10.13), ios(11.0)); Odd that this has WK in the name :| Also the star.
Andy Estes
Comment 3 2019-01-28 15:41:42 PST
(In reply to Tim Horton from comment #2) > Comment on attachment 360387 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360387&action=review > > > Source/WebKit/UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:38 > > - (id)_initWithWKContentRuleListStore:(WKContentRuleListStore*)contentRuleListStore WK_API_AVAILABLE(macosx(10.13), ios(11.0)); > > Odd that this has WK in the name :| Also the star. Indeed :( Will drive-by fix the star, at least.
Andy Estes
Comment 4 2019-01-28 15:42:47 PST
Created attachment 360390 [details] Patch
WebKit Commit Bot
Comment 5 2019-01-28 17:12:36 PST
Comment on attachment 360390 [details] Patch Clearing flags on attachment: 360390 Committed r240624: <https://trac.webkit.org/changeset/240624>
WebKit Commit Bot
Comment 6 2019-01-28 17:12:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-01-28 17:13:30 PST
<rdar://problem/47617634>
Note You need to log in before you can comment on or make changes to this bug.