Bug 193896

Summary: [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

alan
Reported 2019-01-27 21:55:33 PST
<div style="border: 1px solid green"> <div> <p> </div> </div> p's 16px quirk margin gets collapsed all the way up.
Attachments
Patch (15.82 KB, patch)
2019-01-28 08:09 PST, alan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2019-01-28 08:09:55 PST
Created attachment 360342 [details] Patch
Antti Koivisto
Comment 2 2019-01-28 08:15:40 PST
Comment on attachment 360342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360342&action=review > Source/WebCore/ChangeLog:8 > + This patch implements quirk margin value collpasing. There are a few "quirk" rules when it comes to margin collapsing. collapsing > Source/WebCore/ChangeLog:29 > + - the collpased after value stays 1qem quirk value. collapsed
alan
Comment 3 2019-01-28 08:20:25 PST
Committed r240583: <https://trac.webkit.org/changeset/240583>
Radar WebKit Bug Importer
Comment 4 2019-01-28 08:21:28 PST
<rdar://problem/47597463>
Note You need to log in before you can comment on or make changes to this bug.