Bug 193893

Summary: Scrolling with background-attachment: fixed needs to trigger repaints
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dino, esprehn+autocc, ews-watchlist, fred.wang, glenn, jamesr, koivisto, kondapallykalyan, luiz, pdr, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dino: review+
Patch none

Simon Fraser (smfr)
Reported 2019-01-27 21:06:10 PST
Need to make background-attachment: fixed in accelerated overflow:scroll either work, or kick us out of async scrolling.
Attachments
Patch (22.03 KB, patch)
2020-04-20 12:23 PDT, Simon Fraser (smfr) 		dino: review+
DetailsFormatted DiffDiff
Patch (23.46 KB, patch)
2020-04-20 13:04 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-27 21:06:38 PST
<rdar://problem/47587017>
Simon Fraser (smfr)
Comment 2 2020-04-20 12:21:22 PDT
*** Bug 210758 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 3 2020-04-20 12:23:21 PDT
Created attachment 397000 [details] Patch
Dean Jackson
Comment 4 2020-04-20 12:27:22 PDT
Comment on attachment 397000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397000&action=review > LayoutTests/scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-repaint.html:27 > + let scroller = document.querySelector('.scroller'); Antoine would nit const you here. But to that I say: https://www.instagram.com/tv/B_FoCbNHR71/
Simon Fraser (smfr)
Comment 5 2020-04-20 13:04:51 PDT
Created attachment 397007 [details] Patch
EWS
Comment 6 2020-04-20 14:55:42 PDT
Committed r260403: <https://trac.webkit.org/changeset/260403> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397007 [details].
Note You need to log in before you can comment on or make changes to this bug.